Lazy loading technique for React style paths #1227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Build failure seems to be caused by incorrect pipeline rather than code issue |
Member
|
Thanks, it might be a little bit before i can get to this but I’ll take a
look!
…On Thu, Nov 19, 2020 at 1:34 PM, Václav Holuša ***@***.***> wrote:
Allows optionally generate React Styles using Lazy technique where tags
are written using JavaScript that is launched after DOM is loaded.
------------------------------
You can view, comment on, or merge this pull request online at:
#1227
Commit Summary
- Lazy loading technique for React style paths
File Changes
- *M* src/React.AspNet/HtmlHelperExtensions.cs
<https://github.com/reactjs/React.NET/pull/1227/files#diff-f30444ccc89baf4f57e18859d2febf610469d60a75031be3947171727b1176df>
(20)
- *M* tests/React.Tests/Mvc/HtmlHelperExtensionsTests.cs
<https://github.com/reactjs/React.NET/pull/1227/files#diff-d7a7ac7784e29b2457dd0b83ae48c1898bb792c12c555e327b1c08c5df223ae1>
(12)
Patch Links:
- https://github.com/reactjs/React.NET/pull/1227.patch
- https://github.com/reactjs/React.NET/pull/1227.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1227>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHGCFSARTVYF3PUV5CWCALSQWFPZANCNFSM4T36OUFQ>
.
|
Author
|
@dustinsoftware Hi, have you had a chance to take a look? |
Member
|
Sorry - some personal stuff has come up, I won’t be able to look at this
for a while :(
…On Sun, Jan 17, 2021 at 13:50, Václav Holuša ***@***.***> wrote:
@dustinsoftware <https://github.com/dustinsoftware> Hi, have you had a
chance to take a look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1227 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHGCFSH5ED7HELPQA7HBJ3S2NLTLANCNFSM4T36OUFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows optionally generate React Styles using Lazy technique where tags are written using JavaScript that is launched after DOM is loaded.